Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated tf (12.29) and validator (2020-09-24) versions #71

Merged
merged 5 commits into from
Oct 26, 2020

Conversation

mikelaramie
Copy link
Contributor

To fix issue #70 - Updated the versions of terraform 0.12 and terraform-validator to the latest versions

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! @mikelaramie we can also replace the defaults here

variable "terraform_version" {

@mikelaramie
Copy link
Contributor Author

Oh, I didn't see those! I can update those as well; or do you think it's better in general to leave the defaults at an older version and let people modify it themselves?

@bharathkkb
Copy link
Member

@mikelaramie I think it makes sense to update all defaults but will defer to @rjerrems

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems rjerrems merged commit 74d7ef2 into terraform-google-modules:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants