Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Project Factory 7.0 #9

Merged
merged 4 commits into from
Jan 23, 2020
Merged

Upgrade to Project Factory 7.0 #9

merged 4 commits into from
Jan 23, 2020

Conversation

morgante
Copy link
Contributor

BREAKING CHANGE: Upgrade to Project Factory 7.0, requiring Google Provider 3.x

Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just need to figure out the provider versions and also update the cloudbuild submodule

main.tf Show resolved Hide resolved
versions.tf Show resolved Hide resolved
Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, thanks!

@morgante morgante merged commit b0bb86b into master Jan 23, 2020
@morgante morgante deleted the feature/version branch January 23, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants