feat: migrate to GAR for runner images #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
rjerrems
reviewed
Feb 21, 2021
rjerrems
reviewed
Feb 21, 2021
| @@ -277,9 +282,6 @@ resource "google_organization_iam_member" "cloudbuild_serviceusage_consumer" { | |||
| org_id = var.org_id | |||
| role = "roles/serviceusage.serviceUsageConsumer" | |||
| member = "serviceAccount:${module.cloudbuild_project.project_number}@cloudbuild.gserviceaccount.com" | |||
| depends_on = [ | |||
| google_project_service.cloudbuild_apis, | |||
There was a problem hiding this comment.
is it safe to remove these? Previously there was race conditions with APIs being enabled & the SA existing in time for permissions to be applied.
There was a problem hiding this comment.
new PF release will have that output
terraform-google-modules/terraform-google-project-factory#549
rjerrems
approved these changes
Feb 21, 2021
Closed
|
Should we mark this as a breaking change @bharathkkb or I suppose the older image in GCR will remain regardless since it is built with gcloud? Can you also rebase from master :) |
|
@rjerrems this should not be a breaking change as the older image will continue to live in GCR. Rerun would just create a new image in GAR and users can switch to GAR image if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #91