Allow datapath_provider in GA main module #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somethingnew2-0
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
bharathkkb
requested changes
Jan 6, 2022
There was a problem hiding this comment.
Thanks for the PR @somethingnew2-0
Looks like we will also need to bump
|
Hello. Is anyone looking to finish this work or I can pick it up and finish it? |
somethingnew2-0
force-pushed
the
datapath_provider-main-ga
branch
from
b43d1be
to
847a214
Compare
|
@bharathkkb @alexandruivan rebased and fixed the version issue |
morgante
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor implementing #1074
Had to bump the main module GA google provider to 3.55.0 to enable
datapath_providerbeing GA https://github.com/hashicorp/terraform-provider-google/blob/e2e533f83c388fecbf51ae8ca541326b152cede0/CHANGELOG.md#3550-february-1-2021