Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create separate firewall rule for egress to TPUs #1126

Merged
merged 1 commit into from
Jan 13, 2022
Merged

fix: Create separate firewall rule for egress to TPUs #1126

merged 1 commit into from
Jan 13, 2022

Conversation

tomasgareau
Copy link
Contributor

Addresses #1124.

I bumped into this when trying to create a safer-cluster in a VPC network with a default deny egress rule. The intra_egress firewall rule was required to allow the default pool to report back to the control plane so it could be deleted (as part of the google_container_cluster.primary create operation).

However, the intra_egress firewall rule had a Terraform dependency on the google_container_cluster.primary resource, so it was never created, preventing the cluster from creating successfully.

This PR simply creates a separate rule for egress to the tpu_ipv4_cidr_block, allowing the intra_egress rule to get created before the google_container_cluster resource.

@comment-bot-dev
Copy link

comment-bot-dev commented Jan 13, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants