feat!: update TPG version constraints to 4.0 #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
bharathkkb
force-pushed
the
1071-branch-provider-update
branch
2 times, most recently
from
596bcbb
to
0dccbb7
Compare
* addresses warning about multiple provider blocks
* fetches main branch by default?
* temporary change until new version is released
* temporary change until new version of that dependency is released
* this should be removed once hashicorp/terraform-provider-google#10494 is addressed
bharathkkb
force-pushed
the
1071-branch-provider-update
branch
from
0dccbb7
to
2d8e5eb
Compare
bharathkkb
changed the title
bharathkkb
commented
Jan 21, 2022
| @@ -112,6 +112,7 @@ resource "google_compute_firewall" "master_webhooks" { | |||
| direction = "INGRESS" | |||
|
|
|||
| source_ranges = [local.cluster_endpoint_for_nodes] | |||
| source_tags = [] | |||
There was a problem hiding this comment.
Workaround for hashicorp/terraform-provider-google#10494. Long term fix maybe GoogleCloudPlatform/magic-modules#5526 but will need to validate.
bharathkkb
changed the title
|
@morgante PTAL since I rebased this and added a few commits |
morgante
suggested changes
Jan 21, 2022
| } | ||
| ``` | ||
|
|
||
| ### Acceptable values for node_metadata modified |
There was a problem hiding this comment.
Instead of requiring users to change this, I think we can provide a mapping at very low effort to ourselves. Could you add that?
There was a problem hiding this comment.
I updated the doc in e83bfc3 to make this a recommendation instead, encouraging users to switch to values that are supported by the provider.
morgante
approved these changes
Jan 21, 2022
Co-authored-by: Morgante Pell <morgantep@google.com>
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based off of #1071 since I didnt have permission to push to the fork branch