-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GKE autopilot support #1148
Conversation
Thanks for the PR! 🚀 |
@cmcga1125 can you sign the CLA? If you want credit on the PR. Otherwise I'll have to remove your commits from the PR. |
@bharathkkb any insight on what kitchen test is failing? |
@jmymy It may have been a flake since it was for a different test
|
nope that one was me. I found an issue with the merge/rebase and the new identity config.. Should be fixed. |
@bharathkkb next steps? I figured i'd give @cmcga1125 more time while ya'll review the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
CLA submitted! Thanks for taking it across the finish line! Sorry I didn't have enough permissions to test on my account 🙃 |
@bharathkkb how do y'all normally handle the version file in |
@jmymy I noticed it when working on another PR. You can switch to the registry source https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/99e8f9b88eff8363eb7a06faff79e460c049ac35/test/setup/main.tf |
Opened #1159 since it was affecting a few PRs |
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
@bharathkkb next steps? Trying to not let this get stale |
Tests are failing. Please fix integration tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated tests are failing due to flakes
No description provided.