fix: trim trailing dash from gcp SA name in WorkloadIdentity #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per noted regexp, the service account name cannot end with a dash. This can happen when the name is over 30 characters long and so a substring is extracted, but the 30th character happens to be a dash.
sbienkow-ninja
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for the PR! 🚀 |
bharathkkb
approved these changes
May 13, 2022
There was a problem hiding this comment.
Thanks for the PR @sbienkow-ninja
Test failure looks unrelated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per noted regexp, the service account name cannot end with a dash.
This can happen when the name is over 30 characters long
and so a substring is extracted, but the 30th character happens to be a
dash.