Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autopilot also supports managed prometheus #1310

Merged
merged 2 commits into from
Jun 30, 2022
Merged

fix: autopilot also supports managed prometheus #1310

merged 2 commits into from
Jun 30, 2022

Conversation

ykzts
Copy link
Contributor

@ykzts ykzts commented Jun 27, 2022

Follow-up #1307

#1307 is missing Autopilot support. This Pull Request will allow Managed Prometheus to be used with Autopilot as well.

@ykzts ykzts requested review from a team, Jberlinsky and bharathkkb as code owners June 27, 2022 17:06
@comment-bot-dev
Copy link

@ykzts
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ykzts

@bharathkkb bharathkkb merged commit 568c824 into terraform-google-modules:master Jun 30, 2022
@ykzts ykzts deleted the fix/autopilot-managed-prom branch June 30, 2022 10:37
@dkamenov-fitted
Copy link

@ykzts, how are you able to get a managed prometheus instance on an Auto Pilot GKE instance?

Error: googleapi: Error 400: Managed Prometheus is not supported for Autopilot clusters., badRequest

This was the error I got back when trying to enable the managed Prometheus instance on such a GKE instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants