fix: Exposing VPA to GA module #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyz
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Please review @bharathkkb @Jberlinsky |
|
Hi @bharathkkb @Jberlinsky , could you please review at your convenience? |
bharathkkb
reviewed
Oct 6, 2022
There was a problem hiding this comment.
Sorry for the delay @ericyz. Just so I understand this correctly based on the PR contents, we are not adding the VPA feature but rather just exposing the output in GA modules. In the future, adding a PR description would be great so it is easier for us to correlate the intention behind the PR with the code changes.
|
@bharathkkb - thanks for getting back. Yes, agree and I'll add the description in more details in future. |
|
@ericyz |
bharathkkb
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical pod scaling has been availble in the GA Terraform Provider. This change will expose the feature in the existing GA module.