Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Adding Support for Cost Allocation Feature in Beta #1413

Conversation

akshaybathija-github
Copy link
Contributor

PR for adding Support fort Cost Allocation in Beta Modules, Issue #1392

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @akshaybathija-github
This is a breaking change since we will also have to bump the min provider versions to 4.35.

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
modules/beta-autopilot-public-cluster/cluster.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title Adding Support for Cost Allocation Feature in Beta feat!: Adding Support for Cost Allocation Feature in Beta Sep 27, 2022
@Dev25
Copy link
Contributor

Dev25 commented Oct 26, 2022

Apologies for the bump but it seems all changes have been addressed, any chance we can merge this one in now? @bharathkkb

@bharathkkb
Copy link
Member

@Dev25 Yes! We were holding to release a minor version. I will merge this soon.

@comment-bot-dev
Copy link

@akshaybathija-github
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit ba3dcd0 into terraform-google-modules:master Nov 2, 2022
@akshaybathija-github akshaybathija-github deleted the enhancement/support_for_cost_allocation branch November 28, 2022 03:52
@akshaybathija-github akshaybathija-github restored the enhancement/support_for_cost_allocation branch November 28, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants