Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add location_policy and fix permadiff #1452

Merged
merged 1 commit into from
Nov 7, 2022
Merged

feat: add location_policy and fix permadiff #1452

merged 1 commit into from
Nov 7, 2022

Conversation

bogaertg
Copy link
Contributor

@bogaertg bogaertg commented Nov 4, 2022

No description provided.

@bogaertg bogaertg changed the title Feat/location policy fixed GitHub Issue #1445 | location_policy permadrifting with CLA Nov 4, 2022
@bogaertg bogaertg mentioned this pull request Nov 4, 2022
Closed
@bogaertg bogaertg marked this pull request as ready for review November 4, 2022 10:50
bharathkkb
bharathkkb reviewed Nov 4, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our test beta-cluster-local seem to be failing with
Error: error creating NodePool: googleapi: Error 400: Location policy cannot be set for nodepools in clusters that does not support the feature. I suspect this is due to the limitation that Location policy is supported only in 1.24.1+ clusters. per https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#nested_autoscaling

Can we default to null instead if no explicit value is provided?

@comment-bot-dev
Copy link

@bogaertg
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bogaertg
Copy link
Contributor Author

bogaertg commented Nov 7, 2022

Our test beta-cluster-local seem to be failing with Error: error creating NodePool: googleapi: Error 400: Location policy cannot be set for nodepools in clusters that does not support the feature. I suspect this is due to the limitation that Location policy is supported only in 1.24.1+ clusters. per https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_node_pool#nested_autoscaling

Can we default to null instead if no explicit value is provided?

done

@bharathkkb bharathkkb changed the title fixed GitHub Issue #1445 | location_policy permadrifting with CLA feat: add location_policy and fix permadiff Nov 7, 2022
@bharathkkb bharathkkb merged commit aecccf0 into terraform-google-modules:master Nov 7, 2022
@release-please release-please bot mentioned this pull request Nov 7, 2022
Merged
This was referenced Nov 7, 2022
Merged
Closed
@bogaertg bogaertg deleted the feat/location-policy branch November 8, 2022 08:49
@jawnsy jawnsy mentioned this pull request Nov 24, 2022
Closed
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bogaertg @comment-bot-dev @bharathkkb