Add support for https_proxy parameter for the config_sync.git block #1457
Conversation
muresan
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@muresan |
|
@bharathkkb I haven't contributed here for a while (although I'm excited to get back into it :) ) so I'm not comfortable approving myself, but @muresan and I are working on a customer engagement together where this is necessary -- it would be great to get a rapid review of this one. |
There was a problem hiding this comment.
@muresan Thanks for the PR! The build failure looks unrelated.
@Jberlinsky np :)
…lock (terraform-google-modules#1457) * Add support for https_proxy parameter for the config_sync.git block * Changes post make buid and make docker_generate_docs runs
* feat: Add support for https_proxy parameter for the config_sync.git block (#1457) * Add support for https_proxy parameter for the config_sync.git block * Changes post make buid and make docker_generate_docs runs * switch default to true as next release is breaking * fmt Co-authored-by: Catalin Muresan <muresan@users.noreply.github.com> Co-authored-by: bharathkkb <bharathkrishnakb@gmail.com>
Add support for https_proxy parameter for the config_sync.git block