Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: cost_management_config is out of beta now #1470

Conversation

zmaupin
Copy link
Contributor

@zmaupin zmaupin commented Nov 21, 2022

move the config outside the logic of beta only

@google-cla
Copy link

google-cla bot commented Nov 21, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @zmaupin
Looks like this was moved to GA in 4.42. Could you bump the min provider versions in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/versions.tf.tmpl
and also update the upgrade guide https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/docs/upgrading_to_v24.0.md#minimum-google-provider-versions to include this in the latest breaking release #1447

@bharathkkb bharathkkb changed the title feat: cost_management_config is out of beta now feat!: cost_management_config is out of beta now Nov 21, 2022
@zmaupin zmaupin force-pushed the feat/zmaupin/enable_cost_management_config branch from a11fc2d to b268a1d Compare November 21, 2022 17:32
@zmaupin
Copy link
Contributor Author

zmaupin commented Nov 21, 2022

@bharathkkb Thanks for looking! I have updated the two files you asked me to change.

move the config outside the logic of beta only
@zmaupin zmaupin force-pushed the feat/zmaupin/enable_cost_management_config branch from b268a1d to 8fcccde Compare November 21, 2022 17:53
@comment-bot-dev
Copy link

@zmaupin
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 10ea608 into terraform-google-modules:master Nov 21, 2022
@zmaupin zmaupin deleted the feat/zmaupin/enable_cost_management_config branch November 21, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants