feat!: Promote managed_prometheus to GA #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jberlinsky Can I have more detail about the failing tests? Thanks |
|
Triggering test again |
bharathkkb
changed the title
IIBenII
force-pushed
the
promote_prometheus_ga
branch
from
8786814
to
0817334
Compare
|
@ericyz Tests still fail, can you give me more informations about the error? Sadly I can't run tests on my side due to organisation constraint about public cluster 😢 |
|
@IIBenII - The test passed. Could you please resolve the conflict? Thanks |
|
@ericyz done |
ericyz
requested changes
Jan 3, 2023
IIBenII
force-pushed
the
promote_prometheus_ga
branch
from
791421b
to
2c649a8
Compare
|
@ericyz Thanks for all your feedbacks. According to this documentation https://cloud.google.com/kubernetes-engine/docs/resources/autopilot-standard-feature-comparison I also updated how we handle logging/monitoring for autopilot clusters. |
ericyz
requested changes
Jan 3, 2023
IIBenII
force-pushed
the
promote_prometheus_ga
branch
from
08009af
to
4c38b35
Compare
IIBenII
force-pushed
the
promote_prometheus_ga
branch
from
3d236ba
to
f097554
Compare
IIBenII
force-pushed
the
promote_prometheus_ga
branch
2 times, most recently
from
5ed1ebe
to
a05430b
Compare
|
@ericyz I cleaned the code and took your feedbacks, thanks a lot |
ericyz
requested changes
Jan 4, 2023
IIBenII
commented
Jan 5, 2023
|
@IIBenII |
|
Re-trigger the checks |
ericyz
reviewed
Jan 6, 2023
ericyz
approved these changes
Jan 6, 2023
bharathkkb
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
managed_prometheusoption is now GA since the version 4.46.0