feat!: promote gke_backup_agent_config to ga

[Tolsee]

• promote gke_backup_agent_config to ga

Fixes: #1450

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[Tolsee]

@Jberlinsky Can you please help me understand test failure.

[ericyz]

Error Trace: /workspace/test/integration/private_zonal_with_networking/golden.go:158
Step #75 - "verify private-zonal-with-networking": /workspace/test/integration/private_zonal_with_networking/private_zonal_with_networking_test.go:63
Step #75 - "verify private-zonal-with-networking": /workspace/test/integration/private_zonal_with_networking/terraform.go:415
Step #75 - "verify private-zonal-with-networking": /workspace/test/integration/private_zonal_with_networking/terraform.go:435
Step #75 - "verify private-zonal-with-networking": /workspace/test/integration/private_zonal_with_networking/stages.go:31
Step #75 - "verify private-zonal-with-networking": /workspace/test/integration/private_zonal_with_networking/terraform.go:435
Step #75 - "verify private-zonal-with-networking": Error: Not equal:
Step #75 - "verify private-zonal-with-networking": expected: "{\n "dnsCacheConfig": {},\n "gcePersistentDiskCsiDriverConfig": {\n "enabled": true\n },\n "gcpFilestoreCsiDriverConfig": {},\n "horizontalPodAutoscaling": {},\n "httpLoadBalancing": {},\n "kubernetesDashboard": {\n "disabled": true\n },\n "networkPolicyConfig": {\n "disabled": true\n }\n }"
Step #75 - "verify private-zonal-with-networking": actual : "{\n "dnsCacheConfig": {},\n "gcePersistentDiskCsiDriverConfig": {\n "enabled": true\n },\n "gcpFilestoreCsiDriverConfig": {},\n "gkeBackupAgentConfig": {},\n "horizontalPodAutoscaling": {},\n "httpLoadBalancing": {},\n "kubernetesDashboard": {\n "disabled": true\n },\n "networkPolicyConfig": {\n "disabled": true\n }\n }"
Step #75 - "verify private-zonal-with-networking":
Step #75 - "verify private-zonal-with-networking": Diff:
Step #75 - "verify private-zonal-with-networking": --- Expected
Step #75 - "verify private-zonal-with-networking": +++ Actual
Step #75 - "verify private-zonal-with-networking": @@ -6,2 +6,3 @@
Step #75 - "verify private-zonal-with-networking": "gcpFilestoreCsiDriverConfig": {},
Step #75 - "verify private-zonal-with-networking": + "gkeBackupAgentConfig": {},
Step #75 - "verify private-zonal-with-networking": "horizontalPodAutoscaling": {},
Step #75 - "verify private-zonal-with-networking": Test: TestPrivateZonalWithNetworking
Step #75 - "verify private-zonal-with-networking": Messages: expected addonsConfig to match fixture {
Step #75 - "verify private-zonal-with-networking": "dnsCacheConfig": {},
Step #75 - "verify private-zonal-with-networking": "gcePersistentDiskCsiDriverConfig": {
Step #75 - "verify private-zonal-with-networking": "enabled": true
Step #75 - "verify private-zonal-with-networking": },
Step #75 - "verify private-zonal-with-networking": "gcpFilestoreCsiDriverConfig": {},
Step #75 - "verify private-zonal-with-networking": "horizontalPodAutoscaling": {},
Step #75 - "verify private-zonal-with-networking": "httpLoadBalancing": {},
Step #75 - "verify private-zonal-with-networking": "kubernetesDashboard": {
Step #75 - "verify private-zonal-with-networking": "disabled": true
Step #75 - "verify private-zonal-with-networking": },
Step #75 - "verify private-zonal-with-networking": "networkPolicyConfig": {
Step #75 - "verify private-zonal-with-networking": "disabled": true
Step #75 - "verify private-zonal-with-networking": }
Step #75 - "verify private-zonal-with-networking": }

[ericyz]

You might want to update the https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/integration/private_zonal_with_networking/testdata/TestPrivateZonalWithNetworking.json to include the new attribute.

[Tolsee]

@ericyz can you help with test failure once again? Thank you!

[apeabody]

@ericyz can you help with test failure once again? Thank you!

Hi @Tolsee - It looks to be an ordering issue in: https://github.com/Tolsee/terraform-google-kubernetes-engine/blob/feature/promote-gke_backup_agent_config-to-ga/test/integration/private_zonal_with_networking/testdata/TestPrivateZonalWithNetworking.json#L8

Looks like you need to move "gkeBackupAgentConfig": {} just below "gcpFilestoreCsiDriverConfig": {},.

Step #78 - "verify private-zonal-with-networking":         	            	Diff:
Step #78 - "verify private-zonal-with-networking":         	            	--- Expected
Step #78 - "verify private-zonal-with-networking":         	            	+++ Actual
Step #78 - "verify private-zonal-with-networking":         	            	@@ -6,2 +6,3 @@
Step #78 - "verify private-zonal-with-networking":         	            	     "gcpFilestoreCsiDriverConfig": {},
Step #78 - "verify private-zonal-with-networking":         	            	+    "gkeBackupAgentConfig": {},
Step #78 - "verify private-zonal-with-networking":         	            	     "horizontalPodAutoscaling": {},
Step #78 - "verify private-zonal-with-networking":         	            	@@ -13,4 +14,3 @@
Step #78 - "verify private-zonal-with-networking":         	            	       "disabled": true
Step #78 - "verify private-zonal-with-networking":         	            	-    },
Step #78 - "verify private-zonal-with-networking":         	            	-    "gkeBackupAgentConfig": {}
Step #78 - "verify private-zonal-with-networking":         	            	+    }

[Tolsee]

@apeabody It still failing 🤦🏼. Also, I am unable to run tests locally, so can you help me once more. Thank you.

[ericyz]

Please update as Andrew' commented. LGTM for other code

[comment-bot-dev]

@Tolsee
Thanks for the PR! 🚀
✅ Lint checks have passed.

[ericyz]

LGTM