Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promote config_connector_config to ga #1559

Merged
merged 16 commits into from
Aug 23, 2023
Merged

feat: promote config_connector_config to ga #1559

merged 16 commits into from
Aug 23, 2023

Conversation

Tolsee
Copy link
Contributor

@Tolsee Tolsee commented Feb 7, 2023

@Tolsee Tolsee requested review from a team, Jberlinsky and ericyz as code owners February 7, 2023 15:49
@Tolsee Tolsee changed the title feat!: promote configConnectorConfig to ga feat!: promote config_connector_config to ga Feb 7, 2023
@ericyz
Copy link
Collaborator

ericyz commented Feb 12, 2023

/gcbrun

@ericyz ericyz self-assigned this Feb 12, 2023
@ericyz
Copy link
Collaborator

ericyz commented Feb 12, 2023 •
edited

LGTM and will approve after the integration test passed.

Minor:

@Tolsee Tolsee force-pushed the feat/promote-config_connector_config-to-ga branch from a29034c to 9f6dae9 Compare February 13, 2023 07:25
@Tolsee
Copy link
Contributor Author

Tolsee commented Feb 13, 2023

@ericyz Updated as per your comment. Thanks!

@bharathkkb
Copy link
Member

/gcbrun

@Tolsee
Copy link
Contributor Author

Tolsee commented Feb 14, 2023 •
edited

@bharathkkb Can you please let me know what is the error here?

@bharathkkb
Copy link
Member

/gcbrun

5 similar comments
@ericyz
Copy link
Collaborator

ericyz commented Feb 17, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Feb 17, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Feb 18, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Feb 18, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Feb 18, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Feb 20, 2023 

golden.go:158: 
    	Error Trace:	/workspace/test/integration/simple_regional/golden.go:158
    	            				/workspace/test/integration/simple_regional/simple_regional_test.go:57
    	            				/workspace/test/integration/simple_regional/terraform.go:412
    	            				/workspace/test/integration/simple_regional/terraform.go:432
    	            				/workspace/test/integration/simple_regional/stages.go:31
    	            				/workspace/test/integration/simple_regional/terraform.go:432
    	Error:      	Not equal: 
    	            	expected: "{\n    \"dnsCacheConfig\": {},\n    \"gcePersistentDiskCsiDriverConfig\": {\n      \"enabled\": true\n    },\n    \"gcpFilestoreCsiDriverConfig\": {},\n    \"gkeBackupAgentConfig\": {},\n    \"horizontalPodAutoscaling\": {},\n    \"httpLoadBalancing\": {},\n    \"kubernetesDashboard\": {\n      \"disabled\": true\n    },\n    \"networkPolicyConfig\": {\n      \"disabled\": true\n    }\n  }"
    	            	actual  : "{\n    \"configConnectorConfig\": {},\n    \"dnsCacheConfig\": {},\n    \"gcePersistentDiskCsiDriverConfig\": {\n      \"enabled\": true\n    },\n    \"gcpFilestoreCsiDriverConfig\": {},\n    \"gkeBackupAgentConfig\": {},\n    \"horizontalPodAutoscaling\": {},\n    \"httpLoadBalancing\": {},\n    \"kubernetesDashboard\": {\n      \"disabled\": true\n    },\n    \"networkPolicyConfig\": {\n      \"disabled\": true\n    }\n  }"
    	            	
    	            	Diff:
    	            	--- Expected
    	            	+++ Actual
    	            	@@ -1,2 +1,3 @@
    	            	 {
    	            	+    "configConnectorConfig": {},
    	            	     "dnsCacheConfig": {},
    	Test:       	TestSimpleRegional
    	Messages:   	expected addonsConfig to match fixture {
    	            	    "dnsCacheConfig": {},
    	            	    "gcePersistentDiskCsiDriverConfig": {
    	            	      "enabled": true
    	            	    },
    	            	    "gcpFilestoreCsiDriverConfig": {},
    	            	    "gkeBackupAgentConfig": {},
    	            	    "horizontalPodAutoscaling": {},
    	            	    "httpLoadBalancing": {},
    	            	    "kubernetesDashboard": {
    	            	      "disabled": true
    	            	    },
    	            	    "networkPolicyConfig": {
    	            	      "disabled": true
    	            	    }
    	            	  }

@ericyz
Copy link
Collaborator

ericyz commented Feb 20, 2023

@Tolsee , sorry about the delay. The tests dropped a couple of times, but I have posted the error message in above comment.

@Tolsee Tolsee force-pushed the feat/promote-config_connector_config-to-ga branch from 24dbc3c to d57285e Compare February 22, 2023 13:37
@Tolsee
Copy link
Contributor Author

Tolsee commented Feb 22, 2023 •
edited

@ericyz Can you help running it again. I have updated the testdata based on my understanding of the error message d57285e

@apeabody
Copy link
Contributor

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Feb 23, 2023

/gcbrun

ericyz
ericyz approved these changes Feb 23, 2023
View reviewed changes
Copy link
Collaborator

@ericyz ericyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericyz
Copy link
Collaborator

ericyz commented Feb 23, 2023

@apeabody - I might need your help to peer review and merge at your convenience. Thanks

@github-actions github-actions bot added the Stale label May 12, 2023
@apeabody apeabody removed the Stale label May 12, 2023
@apeabody
Copy link
Contributor

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 15, 2023

/gcbrun

6 similar comments
@ericyz
Copy link
Collaborator

ericyz commented Aug 15, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 15, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 15, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 15, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 17, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 17, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 22, 2023

/gcbrun

@ericyz ericyz changed the title feat!: promote config_connector_config to ga feat: promote config_connector_config to ga Aug 22, 2023
@ericyz
Copy link
Collaborator

ericyz commented Aug 22, 2023

/gcbrun

1 similar comment
@ericyz
Copy link
Collaborator

ericyz commented Aug 22, 2023

/gcbrun

@ericyz
Copy link
Collaborator

ericyz commented Aug 22, 2023

/gcbrun

@ericyz ericyz merged commit ae63848 into terraform-google-modules:master Aug 23, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Aug 23, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyz ericyz ericyz approved these changes

@apeabody apeabody apeabody left review comments

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees

@ericyz ericyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Tolsee @ericyz @bharathkkb @apeabody @g-awmalik