feat: Workload Identity module, to bind roles in various projects for the service account created #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SudharsaneSivamany
requested review from
a team,
Jberlinsky and
ericyz
as code owners
|
/gcbrun |
1 similar comment
|
/gcbrun |
… the service account created
|
/gcbrun |
apeabody
requested changes
Mar 24, 2023
There was a problem hiding this comment.
Thanks for the contribution @SudharsaneSivamany! Please see the comments as ideally we can avoid a breaking change.
modules/workload-identity/main.tf
Outdated
| project = var.project_id | ||
| role = each.value | ||
| project = element(split("=>", each.value), 0) | ||
| role = element(split("=>", each.value), 1) |
There was a problem hiding this comment.
I would recommend using a map(list(string)) rather than string parsing.
There was a problem hiding this comment.
Agreed with your point.
| @@ -85,7 +85,7 @@ variable "automount_service_account_token" { | |||
| } | |||
|
|
|||
| variable "roles" { | |||
| description = "A list of roles to be added to the created service account" | |||
| description = "A list of roles to be added to the created service account for specific projects" | |||
There was a problem hiding this comment.
Currently this would be a breaking change, if possible can we make this backward compatible.
A quick thought might be add a new (optional) map(list(string)) of additional projects=>[roles], and leave the existing roles for just var.project_id?
There was a problem hiding this comment.
Changes are made as mentioned. Pls review
|
/gcbrun |
apeabody
reviewed
Apr 4, 2023
… the service account created
|
/gcbrun |
apeabody
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will help users to bind the created service account account with roles in multiple projects.