feat!: support for enabling image streaming at cluster level #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could previously be set manually via console/`gcloud` - if this was enabled, `enable_gcfs` must be set to `true` with this update, otherwise image streaming will be disabled. Fixes terraform-google-modules#1360
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
/gcbrun |
apeabody
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Thanks for the contribution @lauraseidler!
Good call on the breaking change ! flag.
|
Any reason it is not supported for private cluster ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could previously be set manually via console/
gcloud- if this was enabled,enable_gcfsmust be set totruewith this update, otherwise image streaming will be disabled.Fixes #1360