feat!: align keepers with ForceNew: true fields #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Not stale, still an open issue |
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
apeabody
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Thanks for the contribution @lauraseidler!
Could you add the referenced tf state migration to (new) docs/upgrading_to_v29.0.md
Will cause node pools to be re-created on update, unless remote state of the `random_id` resources is manually modified to reflect the new keepers. Fixes terraform-google-modules#1695
lauraseidler
force-pushed
the
fix/remove-label-keeper
branch
from
4fda7c1
to
1defeaf
Compare
@apeabody sorry, it took me a while to find time for this again - done now :) |
|
/gcbrun |
|
/gcbrun |
apeabody
reviewed
Oct 26, 2023
apeabody
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will cause node pools to be re-created on update, unless remote state
of the
random_idresources is manually modified to reflect the new keepers.Fixes #1695