Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: random zones only when zones are not provided #1709

Merged
merged 1 commit into from
Aug 22, 2023
Merged

fix: random zones only when zones are not provided #1709

merged 1 commit into from
Aug 22, 2023

Conversation

ericyz
Copy link
Collaborator

@ericyz ericyz commented Aug 15, 2023 •
edited

Solves #1442

  • Fixed the test data for integration test
  • Reference the ASM policy library to the latest commit (fix the integration test failure)

@ericyz ericyz requested review from Jberlinsky and a team as code owners August 15, 2023 00:28
@ericyz ericyz force-pushed the fix/read-zones branch 9 times, most recently from 6a16a8f to bd576af Compare August 17, 2023 01:26
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 17, 2023

/gcbrun

1 similar comment
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 17, 2023

/gcbrun

@ericyz
Copy link
Collaborator Author

ericyz commented Aug 18, 2023

/gcbrun

1 similar comment
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 18, 2023

/gcbrun

@ericyz ericyz force-pushed the fix/read-zones branch 3 times, most recently from 5675931 to 6487b2c Compare August 21, 2023 02:08
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 21, 2023

/gcbrun

1 similar comment
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 21, 2023

/gcbrun

@ericyz ericyz force-pushed the fix/read-zones branch 4 times, most recently from 6322000 to 65b85c2 Compare August 21, 2023 05:53
@ericyz
Copy link
Collaborator Author

ericyz commented Aug 21, 2023

/gcbrun

bharathkkb
bharathkkb approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ericyz. A minor comment about the ACM change.

examples/simple_zonal_with_acm/acm.tf Show resolved Hide resolved
@ericyz ericyz merged commit 50ea965 into terraform-google-modules:master Aug 22, 2023
4 checks passed
@ericyz ericyz mentioned this pull request Aug 22, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 22, 2023
Merged
@ericyz ericyz deleted the fix/read-zones branch August 22, 2023 02:54
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericyz @bharathkkb