feat(TPG>=4.81.0)!: add fqdn policies #1729
Conversation
TheKangaroo
requested review from
Jberlinsky,
ericyz and
a team
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
TheKangaroo
force-pushed
the
feat/fqdn-policies
branch
2 times, most recently
from
0c37cdc
to
38430c4
Compare
|
@Jberlinsky @ericyz I fixed a bug in the template and the lint should work now. At least it worked on my local machine. |
|
Hi @TheKangaroo - thank you for your contribution. I'll review and trigger the CI |
|
/gcbrun |
|
A note for myself. The feature introduced in |
|
/gcbrun |
|
LGTM |
|
/gcbrun |
|
I merged the latest changes from master, because of version conflicts. I hope this is ok, I'm not too familiar with the PR process in this repo. |
|
@TheKangaroo - That's all good. Once the Integration test passes, we'll merge |
|
/gcbrun |
1 similar comment
|
/gcbrun |
TheKangaroo
force-pushed
the
feat/fqdn-policies
branch
from
08bc1db
to
e6ea4cf
Compare
apeabody
changed the title
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
Is there anything I need to fix to make the pipeline succeed? I think I cannot see the pipeline output. |
I re-triggered it as the failure didn't appear related to the code change. |
|
Hi, I don't want to bother you but is there anything I can do to get the PR merged soon? We have 'manually' enabled the feature on some clusters and now we can't update the provider until we can set the option via the module. |
|
/gcbrun |
Trigger a fresh run of the CI |
|
/gcbrun |
|
@Jberlinsky @apeabody Can we continue with this PR? |
|
/gcbrun |
|
Thanks for the contribution @TheKangaroo! |
Fixes #1728
Please let me know if anything is missing. This is my first PR to this repo.