feat(acm)!: remove direct kubectl commands

[foosinn]

kubectl-wrapper currently breaks if one has to access the api using a proxy (IAP).

This replaces the wrapper call for all annotations with the kubernetes_annotations resource. The kubernetes provider is already in use for the secret.

In addition it allows the user to disable the automated restart. Sadly it's currently not possible to work around this AFAIK

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[foosinn]

fixed the docs

[apeabody]

/gcbrun

[foosinn]

@apeabody any update on this? would love to switch back to upstream :)

[apeabody]

/gcbrun

[foosinn]

@apeabody I've got some feedback on the kubernetes restart handler:

hashicorp/terraform-provider-kubernetes#2304 (comment)

Would you prefer to leave it as is, or should i update the PR for the recommended solution? I'm not really sure of the use of time_static would have any implications to your release cycle

[apeabody]

@apeabody I've got some feedback on the kubernetes restart handler:

hashicorp/terraform-provider-kubernetes#2304 (comment)

Would you prefer to leave it as is, or should i update the PR for the recommended solution? I'm not really sure of the use of time_static would have any implications to your release cycle

Hi @foosinn - This will be going into major version (#1746), so I would recommend including everything in this PR so any upgrade migration required is only one-time. It appears we already include the time provider as a requirement. Any required upgrade documentation can be added as docs/upgrading_to_v29.0.md

[foosinn]

i'll update tomorrow to the recommended fix.

Can you somehow share the log output of Build 5d254629-88a8-47ca-bc26-da74d399ea9f failed? Seems like it's not public

[apeabody]

i'll update tomorrow to the recommended fix.

Can you somehow share the log output of Build 5d254629-88a8-47ca-bc26-da74d399ea9f failed? Seems like it's not public

Failure appears unrelated (timeout), I've re-triggered the run.

[foosinn]

Switched to the suggested solution and also rebased latest master. Let me know if you need anything else.

Did also a quick test with our fork, seems to work fine :)

[apeabody]

From the linter

Checking submodule's files generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/acm/README.md /tmp/tmp.vcv4AgP5L4/workspace/modules/acm/README.md
98d97
< | restart\_gatekeeper\_controller\_manager | Restart the gatekeeper controller manager after setting up workload id (needs to be done manually if a proxy to gke api is required) | `bool` | `true` | no |
Error: submodule's files generation has not been run, please run the
'make build' command and commit changes
/usr/local/bin/task_helper_functions.sh: line 30: DELETE_AT_EXIT: readonly variable
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/modules/acm/README.md /tmp/tmp.ONYkjFiaEt/generate_docs/workspace/modules/acm/README.md
98d97
< | restart\_gatekeeper\_controller\_manager | Restart the gatekeeper controller manager after setting up workload id (needs to be done manually if a proxy to gke api is required) | `bool` | `true` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.

[foosinn]

And again fixed the docs

[apeabody]

/gcbrun

[apeabody]

/gcbrun

[foosinn]

Can you share the error that happened?

[apeabody]

Thanks for the contribution @foosinn

Marking as a breaking change given the config "churn" window.

[apeabody]

/gcbrun

[foosinn]

thanks!