Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(acm): Allow to enable config_sync or policy_controller standalone #1752

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix(acm): Allow to enable config_sync or policy_controller standalone #1752

merged 1 commit into from
Sep 28, 2023

Conversation

foosinn
Copy link
Contributor

@foosinn foosinn commented Sep 28, 2023

Currently enabling only one of enable_config_sync or enable_policy_controller will cause a string template containing null. See:

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/acm/creds.tf#L47

This removes the null item and creates instead an array of 0 to 2 elements.

@foosinn foosinn requested review from Jberlinsky, ericyz and a team as code owners September 28, 2023 16:54
@apeabody apeabody self-assigned this Sep 28, 2023
@apeabody
Copy link
Contributor

/gcbrun

apeabody
apeabody approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @foosinn!

@apeabody apeabody merged commit abdba8c into terraform-google-modules:master Sep 28, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Sep 27, 2023
Merged
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

@ericyz ericyz Awaiting requested review from ericyz ericyz is a code owner

Assignees

@apeabody apeabody

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foosinn @apeabody