Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make confidential_nodes GA #1815

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

DrFaust92
Copy link
Contributor

No description provided.

@DrFaust92 DrFaust92 requested review from ericyz and a team as code owners December 13, 2023 11:46
@DrFaust92 DrFaust92 changed the title Make confidential_nodes GA feat: Make confidential_nodes GA Dec 13, 2023
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

/gcbrun

@t-indumathy
Copy link

@apeabody May I know the details of failed checks. Don't have access to the build logs.

@apeabody
Copy link
Contributor

@apeabody May I know the details of failed checks. Don't have access to the build logs.

Hi @t-indumathy - It's unclear if this is related to the change, so I'll trigger another run:

TestSimpleZonalWithASM 2024-01-19T01:13:56Z command.go:185: module.example.module.gke.google_container_cluster.primary: Creating...
TestSimpleZonalWithASM 2024-01-19T01:14:06Z command.go:185: module.example.module.gke.google_container_cluster.primary: Still creating... [10s elapsed]
TestSimpleZonalWithASM 2024-01-19T01:14:16Z command.go:185: module.example.module.gke.google_container_cluster.primary: Still creating... [20s elapsed]
TestSimpleZonalWithASM 2024-01-19T01:14:26Z command.go:185: module.example.module.gke.google_container_cluster.primary: Still creating... [30s elapsed]
TestSimpleZonalWithASM 2024-01-19T01:14:31Z command.go:185: 
TestSimpleZonalWithASM 2024-01-19T01:14:31Z command.go:185: Error: Error waiting for creating GKE cluster: Failed to create cluster
TestSimpleZonalWithASM 2024-01-19T01:14:31Z command.go:185: 
TestSimpleZonalWithASM 2024-01-19T01:14:31Z command.go:185:   with module.example.module.gke.google_container_cluster.primary,
TestSimpleZonalWithASM 2024-01-19T01:14:31Z command.go:185:   on ../../../cluster.tf line 22, in resource "google_container_cluster" "primary":
TestSimpleZonalWithASM 2024-01-19T01:14:31Z command.go:185:   22: resource "google_container_cluster" "primary" {

@t-indumathy
Copy link

@DrFaust92 Can you please sync your fork with upstream to reflect the new changes.

@apeabody
Copy link
Contributor

/gcbrun

@t-indumathy
Copy link

@apeabody Kindly review.

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @DrFaust92!

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody enabled auto-merge (squash) January 26, 2024 17:12
@apeabody apeabody self-assigned this Jan 26, 2024
@apeabody apeabody merged commit 322a5ee into terraform-google-modules:master Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants