Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Auto Provisioning/NAP full support, including upgrade_settings, autoprovisioning-locations #1846

Closed
Shaked opened this issue Jan 15, 2024 · 1 comment
Labels
enhancement New feature or request Stale

Comments

@Shaked
Copy link

Shaked commented Jan 15, 2024

TL;DR

Add support for:

gcloud container clusters update CLUSTER_NAME \
    --region europe-west1 \
   --autoprovisioning-locations="europe-west1-b,europe-west1-c,europe-west1-d"
    --enable-autoprovisioning \
    --autoprovisioning-max-surge-upgrade '2' \
    --autoprovisioning-max-unavailable-upgrade '0'

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#nested_auto_provisioning_defaults

It should be under the `upgrade_settings` argument.

Detailed design

cluster_autoscaling = {
    enabled             = true
    min_cpu_cores       = 1
    max_cpu_cores       = 1000
    min_memory_gb       = 1
    max_memory_gb       = 100000
    autoscaling_profile = "OPTIMIZE_UTILIZATION"
    gpu_resources = [{...}]
    auto_repair  = true
    auto_upgrade = true
    # missing parts below
    zones        = ...
    max_surge = .. 
    max_unavailable = ...
  }


### Additional information

https://cloud.google.com/kubernetes-engine/docs/how-to/node-auto-provisioning#defaults
@Shaked Shaked added the enhancement New feature or request label Jan 15, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 31, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

1 participant