-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to use an existing certificate #10
Comments
@lexelby Maybe make a pull request from that Fastly repo to this repo? |
Sure, I'd be happy to. But CONTRIBUTING.md says to open an issue and wait for a maintainer to ask me to submit a PR if they like the idea. |
Ah, my bad. Thanks for sharing this. |
@lexelby if you don't mind me asking, how do you get a reference to the |
@eltimn Like this:
|
Excellent. Thank you! |
@danisla @danawillow Code for this is working and tested in our environment. How can I help you folks to get this moving? My employer (Fastly) has signed a CLA that includes me, so that shouldn't be a stumbling block. |
This is great, please create a PR and I'll get it merged. |
Fixed with #16 |
We would find it useful to be able to pass in the
self_link
of an existing certificate tolb-http
. This would allow us to create the certificate outside of terraform to avoid having key material in the tfstate file.I've implemented this feature in our fork: fastly#1
To my understanding, Fastly already has a corporate CLA, and I've been added to it. If this all looks good to you, I'll create a PR.
The text was updated successfully, but these errors were encountered: