Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to use an existing certificate #10

Closed
lexelby opened this issue Apr 4, 2018 · 10 comments
Closed

option to use an existing certificate #10

lexelby opened this issue Apr 4, 2018 · 10 comments

Comments

@lexelby
Copy link

lexelby commented Apr 4, 2018

We would find it useful to be able to pass in the self_link of an existing certificate to lb-http. This would allow us to create the certificate outside of terraform to avoid having key material in the tfstate file.

I've implemented this feature in our fork: fastly#1

To my understanding, Fastly already has a corporate CLA, and I've been added to it. If this all looks good to you, I'll create a PR.

@neomantra
Copy link
Contributor

@lexelby Maybe make a pull request from that Fastly repo to this repo?

@lexelby
Copy link
Author

lexelby commented Apr 26, 2018

Sure, I'd be happy to. But CONTRIBUTING.md says to open an issue and wait for a maintainer to ask me to submit a PR if they like the idea.

@neomantra
Copy link
Contributor

Ah, my bad. Thanks for sharing this.

@eltimn
Copy link

eltimn commented Apr 27, 2018

@lexelby if you don't mind me asking, how do you get a reference to the self_link of an existing certificate?

@lexelby
Copy link
Author

lexelby commented Apr 27, 2018

@eltimn Like this:

gcloud compute ssl-certificates list --project <project ID> --uri

@eltimn
Copy link

eltimn commented Apr 28, 2018

Excellent. Thank you!

@lexelby
Copy link
Author

lexelby commented Jun 12, 2018

@danisla @danawillow Code for this is working and tested in our environment. How can I help you folks to get this moving? My employer (Fastly) has signed a CLA that includes me, so that shouldn't be a stumbling block.

@danisla
Copy link
Contributor

danisla commented Jun 14, 2018

This is great, please create a PR and I'll get it merged.

@lexelby
Copy link
Author

lexelby commented Jun 14, 2018

@danisla created: #19

Interestingly, #18 seems to also have the same bring-your-own-cert functionality.

@danisla
Copy link
Contributor

danisla commented Jun 25, 2018

Fixed with #16

@danisla danisla closed this as completed Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants