feat!: Add support for custom time periods in budget module #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
reviewed
Aug 9, 2022
bharathkkb
reviewed
Aug 16, 2022
bharathkkb
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
A last request - I just noticed this relies on provider version 4.28+
We should also update
terraform-google-project-factory/versions.tf
Lines 19 to 27 in 9410ca4
and
terraform-google-project-factory/modules/budget/versions.tf
Lines 20 to 25 in 9410ca4
to use
~> 4.28
bharathkkb
changed the title
|
@abhisek00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the #729