Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support optional tag binding #885

Merged
merged 8 commits into from
Mar 1, 2024
Merged

feat: support optional tag binding #885

merged 8 commits into from
Mar 1, 2024

Conversation

bharathkkb
Copy link
Member

fixes #884

@bharathkkb bharathkkb requested a review from a team as a code owner February 21, 2024 23:46
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. My comments center around the lack of usage of google_tags_tag_key in the module? AFAIK, the key and the value are paired together for the binding and we should give the user the ability to create both. What do you think?

modules/core_project_factory/variables.tf Show resolved Hide resolved
test/setup/tags.tf Outdated Show resolved Hide resolved
@g-awmalik g-awmalik self-assigned this Feb 22, 2024
@bharathkkb
Copy link
Member Author

bharathkkb commented Feb 23, 2024

My comments center around the lack of usage of google_tags_tag_key in the module? AFAIK, the key and the value are paired together for the binding and we should give the user the ability to create both. What do you think?

My reasoning for this was the common use case seems to be that keys (and values) are defined at a higher level (org/folder) and only binding is performed at the project during creation time. There could be usecases where maybe project scoped tags are created but I am thinking we should recommend use the tags module for that.

This would be similar to how we only allow attaching to a shared VPC via PF while requiring network module for full create functionality.

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions - saw the existing comment one why this doesn't need to be a breaking change.

build/int.cloudbuild.yaml Outdated Show resolved Hide resolved
examples/tags_project/variables.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit 87648a1 into master Mar 1, 2024
8 checks passed
@bharathkkb bharathkkb deleted the add-pf-tag branch March 1, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for binding a tag with project
3 participants