Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add depends on replicas for user creation #268

Merged

Conversation

g-awmalik
Copy link
Contributor

@g-awmalik g-awmalik commented Dec 29, 2021

This is an interim fix for this issue
Additionally, it uses the custom machine types for the postgresql examples since the shared instance was taking too long and timing out.

@comment-bot-dev
Copy link

comment-bot-dev commented Dec 29, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use timeouts for this. That's not the right fix.

If there are issues with parallelism, the correct fix is to adjust the depends_on so it doesn't start until the earlier resources are done.

We should never expose timeout parameters to users.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this for mysql too

@g-awmalik
Copy link
Contributor Author

@bharathkkb - I can do that as another PR. Let's let this go through to unblock the customer for now.

@bharathkkb bharathkkb changed the title fix:adds user timeouts as a module variables fix: add depends on replicas for user creation Jan 4, 2022
@bharathkkb bharathkkb merged commit d45df79 into terraform-google-modules:master Jan 4, 2022
@morgante
Copy link
Contributor

@g-awmalik Can you add this for mysql and mssql? I want to get those into the release.

@g-awmalik
Copy link
Contributor Author

@morgante - this includes the change for MySql as well. However, this module doesn't include replica setup for MSSQL yet. I can work on that but we may want to push these changes for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants