Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add support for setting disk_autoresize_limit #288

Conversation

kostiantyn-nemchenko
Copy link
Contributor

This PR allows configuring the disk_autoresize_limit property available in the google_sql_database_instance resource since Google provider version 3.70.0.

Adding this property to Cloud SQL modules will allow users to set a specific limit on how large the storage on their instance can automatically grow.

@google-cla
Copy link

google-cla bot commented Mar 24, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@kostiantyn-nemchenko
Copy link
Contributor Author

@bharathkkb @morgante please kindly take a look and let me know what you think. Thank you

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and adding tests @kostiantyn-nemchenko
Could you also add an upgrade guide like https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/docs/upgrading_to_sql_db_4.0.0.md since this is a breaking change

@kostiantyn-nemchenko
Copy link
Contributor Author

@bharathkkb The upgrade guide is added. Please, check it out. Thank you.

@bharathkkb
Copy link
Member

Thanks @kostiantyn-nemchenko. This will be merged in our next breaking release.

@bharathkkb bharathkkb changed the title Add support for setting disk_autoresize_limit feat!: Add support for setting disk_autoresize_limit May 19, 2022
bharathkkb
bharathkkb previously approved these changes May 19, 2022
docs/upgrading_to_sql_db_11.0.0.md Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@kostiantyn-nemchenko
Thanks for the PR! 🚀
✅ Lint checks have passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants