Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to compress backups for PostreSQL and MySQL #335

Merged

Conversation

gleichda
Copy link
Contributor

@gleichda gleichda commented Aug 8, 2022

The API Spec allows to compress the Backup by just adding a .gz to a export of type SQL

Edit: As API Activation was failing multiple times again during build. Increasing the waiting time for API Activation to 900s=15min which should bring up build success again

@bharathkkb
Copy link
Member

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but LGTM

modules/backup/templates/export.yaml.tftpl Outdated Show resolved Hide resolved
modules/backup/variables.tf Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@gleichda
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit b1ef34d into terraform-google-modules:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants