Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add name_override variable for MySQL, PostgreSQL and safer_sql to Override default read replica name #393

Merged
merged 34 commits into from
Jan 4, 2023
Merged

feat: Add name_override variable for MySQL, PostgreSQL and safer_sql to Override default read replica name #393

merged 34 commits into from
Jan 4, 2023

Conversation

aniketkumarj
Copy link
Contributor

@aniketkumarj aniketkumarj commented Dec 16, 2022 •
edited by apeabody

Added the name_override variable for read_replicas to fix the following issue: #266

Added it for the case of MySQL , safer_sql and Postgres module

BEGIN_COMMIT_OVERRIDE
feat!: Add name_override variable for MySQL, PostgreSQL and safer_sql to Override default read replica name (#393)
END_COMMIT_OVERRIDE

@aniketkumarj aniketkumarj requested a review from a team as a code owner December 16, 2022 10:29
@aniketkumarj aniketkumarj reopened this Dec 16, 2022
@aniketkumarj aniketkumarj changed the title Override default read replica name feat: Add name_override variable for MySQL, PostgreSQL and safer_sql toOverride default read replica name Dec 16, 2022
@aniketkumarj aniketkumarj changed the title feat: Add name_override variable for MySQL, PostgreSQL and safer_sql toOverride default read replica name feat: Add name_override variable for MySQL, PostgreSQL and safer_sql to Override default read replica name Dec 16, 2022
@aniketkumarj aniketkumarj marked this pull request as draft December 19, 2022 10:06
@comment-bot-dev
Copy link

@aniketkumarj
Thanks for the PR! 🚀
✅ Lint checks have passed.

@aniketkumarj aniketkumarj marked this pull request as ready for review January 3, 2023 04:26
g-awmalik
g-awmalik approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-awmalik g-awmalik merged commit 045bed1 into terraform-google-modules:master Jan 4, 2023
@release-please release-please bot mentioned this pull request Jan 4, 2023
Merged
@ykyr ykyr mentioned this pull request Jan 12, 2023
Merged
@bharathkkb
Copy link
Member

Hi @aniketkumarj, looks like this change introduced optionals and it is a breaking change. Could you update the minimum supported TF version to 1.3.0 and add this to our upgrade guide https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/docs/upgrading_to_sql_db_14.0.0.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aniketkumarj @comment-bot-dev @bharathkkb @g-awmalik