feat: Add deny_maintenance_period for MySQL, MsSQL, PostgreSQL and safer_sql
#399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketkumarj
force-pushed
the
DenyMaintenancePeriod
branch
from
f48decb
to
25de437
Compare
bharathkkb
previously requested changes
Dec 29, 2022
There was a problem hiding this comment.
Thanks for the PR @aniketkumarj
Could you bump the min provider version throughout as it looks like this was added in 4.45
|
@aniketkumarj - can you update the min version in all modules versions.tf. Here's an example |
g-awmalik
requested changes
Jan 4, 2023
|
@bharathkkb - I think your comment has been addressed as well but please confirm. |
|
@aniketkumarj |
g-awmalik
dismissed
bharathkkb’s stale review
Addressed with bumping the min. version in versions.tf
I've dismissed your review since you and I were both asking for the same thing and its had been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
deny_maintenance_periodwith fieldsend_date,start_dateandtimefor different databases i.e MySQL, MsSQL, PostgreSQL and safer_sql to fix the following issue: #391