feat!: adds settings.deletion_protection_enabled to modules #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
apeabody
requested changes
Jan 11, 2023
There was a problem hiding this comment.
Thanks for the contribution @KelvinVenancio!
Please increase the relevant provider versions to >= 4.48.0 for the new capability as well. For example:
apeabody
changed the title
|
Hi @apeabody, you're welcome. Sorry, completely forgot, my mistake. I have fixed it now. Thank you. |
apeabody
approved these changes
Jan 11, 2023
|
@KelvinVenancio |
bharathkkb
approved these changes
Jan 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team,
The new provider version 4.48.0 introduced a new feature
deletion_protection_enabledto guard against deletion from all surfaces. We would like to use this feature together with the existingdeletion_protectionthat already blocks deletion via Terraform.Until version 4.47.0, we activated this option manually and since it didn't exist in the provider, it didn't drift. Today, we have more than 50 database instances between MySQL and PostgreSQL alarming drift due to this feature of the provider. This PR corrects and resolves this issue.
We appreciate if this can make it into the 14.0.0 release that will be released (if there are no errors and/or considerations in this PR, of course.).
Thanks.