fix!: pass iam_user_emails as map to postgres module

[mnahkies]

this solves the Error: Invalid for_each argument issue that occurs if you try to create a service account and database in the same root module.

(it's a bit awkward but to my knowledge this is the correct way to do it in terraform)

fixes issue #413

Notes
Obviously this is a breaking change - I expect we'll want to add migration instructions to https://github.com/mnahkies/terraform-google-sql-db/blob/7d6b2095f0e2312424c97a416dbb929d57c73eaa/docs/upgrading_to_sql_db_14.0.0.md or the v15 equivalent - ideally I'd like some feedback on whether this change will be accepted before producing these though.

I think it would be nice to get this into the v14 release, given that it already contains other IAM related breaking changes to the postgres module.

[comment-bot-dev]

@mnahkies
Thanks for the PR! 🚀
✅ Lint checks have passed.

[g-awmalik]

Thanks for catching this @mnahkies. Can you make iam_user_emails an object instead of a map so it's clear on what we're setting as values? Something like this should work:

type = list(object({
    id  = string
    email = string
  }))

[mnahkies]

I saw that the minimum supported terraform version is now 1.3.0 since v14 and so I think we should encourage the use of moved blocks over running terraform state mv commands, but let me know if you disagree

[mnahkies]

Thanks for catching this @mnahkies. Can you make iam_user_emails an object instead of a map so it's clear on what we're setting as values? Something like this should work:

type = list(object({
    id  = string
    email = string
  }))

Apologies that it's taken me so long to get back to this @g-awmalik - I was bogged down with life stuff for a few weeks.

I've now:

• Changed type to list(object(...)) as requested
• Written upgrade/migration instructions
• Synced with base branch

If you could please take another look that would be great :)

[mnahkies]

@g-awmalik any chance you would have time to give this a re-review / approve a CI run?

[apeabody]

/gcbrun

[g-awmalik]

/gcbrun

[g-awmalik]

/gcbrun