Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates the TF version constraint to 1.3 #419

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Conversation

g-awmalik
Copy link
Contributor

No description provided.

@g-awmalik g-awmalik requested a review from a team as a code owner February 3, 2023 23:22
@g-awmalik
Copy link
Contributor Author

@bharathkkb - PTAL

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


### Made `name_override` optional in the `read_replica` object
The [`name_override`](https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/modules/postgresql/variables.tf#L232) attribute for [`read_replica`](https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/modules/postgresql/variables.tf#L228) is optional now. If passed, the name for the read replica will be set as such. Since [optional attributes](https://developer.hashicorp.com/terraform/language/expressions/type-constraints#optional-object-type-attributes)
is a version 1.3 feature, the configuration will fail if the pinned version is < 1.3.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Let's call out the TF 1.3 requirement as the heading and provide rationale below regarding name_override

@comment-bot-dev
Copy link

@g-awmalik
Thanks for the PR! 🚀
✅ Lint checks have passed.

@g-awmalik g-awmalik merged commit add16eb into master Feb 4, 2023
@g-awmalik g-awmalik deleted the fix/tf_ver_update branch February 4, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants