Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to avoid password reset for existing additional users for mssql #489

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

Anand-chenepalli
Copy link
Contributor

fix: to avoid password reset for existing additional users

@Anand-chenepalli Anand-chenepalli requested a review from a team as a code owner July 18, 2023 13:27
@Anand-chenepalli Anand-chenepalli changed the title fix: to avoid password reset for existing additional users fix: to avoid password reset for existing additional users for mssql Jul 18, 2023
@g-awmalik
Copy link
Contributor

/gcbrun

@Anand-chenepalli
Copy link
Contributor Author

@g-awmalik can you please run /gcbrun

@vponnam
Copy link
Contributor

vponnam commented Jul 25, 2023

@g-awmalik looks like the earlier /gcbrun didn't actually triggered a build. Appreciate your support in reviewing this PR.

@kam1kaze
Copy link
Contributor

@vponnam @g-awmalik I've faced with the same issue but in MySQL module after upgrade from 14 to 15 major version. Should I create a new PR or we can update this one?

@Anand-chenepalli
Copy link
Contributor Author

@kam1kaze i guess you can contribute to this PR itself

@Anand-chenepalli
Copy link
Contributor Author

@g-awmalik Can you please trigger the /gcbrun again ?

@kam1kaze
Copy link
Contributor

kam1kaze commented Aug 3, 2023

@Anand-chenepalli how could I do that? Just create a PR in your repo/branch (Anand-chenepalli/terraform-google-sql-db/tree/patch-2)?

@Anand-chenepalli
Copy link
Contributor Author

@kam1kaze can you please submit sperate pull request for your changes as there is CLA that need to be signed individually.

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 923cd11 into terraform-google-modules:master Aug 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants