Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added cloudsql serverless_export #530

Merged
merged 13 commits into from
Nov 9, 2023

Conversation

poligraph
Copy link
Contributor

@poligraph poligraph changed the title added cloudsql serverless_export feat: added cloudsql serverless_export Oct 19, 2023
@poligraph poligraph marked this pull request as ready for review October 19, 2023 13:17
@poligraph poligraph requested review from isaurabhuttam and a team as code owners October 19, 2023 13:17
@poligraph
Copy link
Contributor Author

Dear @isaurabhuttam, could please review my PR? I currently use fork from main repo, but would like to use official.
Thanks.

@poligraph
Copy link
Contributor Author

Dear @imrannayer could you please review my PR?

thanks.

@imrannayer
Copy link
Collaborator

@poligraph waiting for PR #523 merge. It has a fix needed for every PR.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

@poligraph is it possible to add a new example to test this feature?

@poligraph
Copy link
Contributor Author

@imrannayer
not sure that I understood you correctly, but here is example,

  source                 = "github.com/terraform-google-modules/terraform-google-sql-db/modules/backup"
  enable_internal_backup = false
  use_serverless_export  = true
  export_schedule        = "00 4 * * *"
  export_uri             = "gs://cloudsql-db-backup"
  region                 = "europe-west2"
  scheduler_timezone     = "Etc/UTC"
  sql_instance           = "cloudsql-prod-db"
}

@imrannayer
Copy link
Collaborator

@poligraph I was wondering if you can add a new example with serverless export.

@poligraph
Copy link
Contributor Author

@imrannayer understood, I have provided example (I use it currently in my project) -- is it enough? or need to add something ?

@imrannayer
Copy link
Collaborator

Can you plz add serverless export feature in this example. This example is executed as part of testing module

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

@poligraph
Copy link
Contributor Author

@imrannayer I have updated example and Readme

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

2 similar comments
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

/gcbrun

@poligraph
Copy link
Contributor Author

@imrannayer , I see that CI/CD check failed, but it was passed previously. Should I fix something, or it's an issue from another merges?

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit aae3181 into terraform-google-modules:master Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants