-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TPG>=5.12)!: Add option to create and failover a replica instance in Postgresql and MsSQL sub-module #582
feat(TPG>=5.12)!: Add option to create and failover a replica instance in Postgresql and MsSQL sub-module #582
Conversation
/gcbrun |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Please review my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please combine main.tf, mssql1.tf and mssql2.tf together into main.tf.
@g-awmalik fixed. Can u plz review? |
Hi Imran, |
@aleksandersumowski thanks for the feedback. PR 16932 is part of [5.12]( |
Could I also ask you why the failover procedure has these preconditions?
|
@aleksandersumowski according to my understanding:
|
No description provided.