Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add submodule with default base access group set #144

Merged
merged 40 commits into from
Jun 11, 2024
Merged

feat: add submodule with default base access group set #144

merged 40 commits into from
Jun 11, 2024

Conversation

MatthewLemmond
Copy link
Member

Description

Add the deployable architecture code to provision a default set of access groups

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
refactor: add skip for DA upgrade test
1eefa17 
SKIP UPGRADE TEST no changes made to base module, skipping for DA upgrade test introduction
@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

ocofaigh
ocofaigh requested changes Mar 29, 2024
View reviewed changes
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Also requesting review from @vburckhardt

PS: Can you add the deployable-architecture topic to .github/settings.yml?

.catalog-onboard-pipeline.yaml Outdated Show resolved Hide resolved
ibm_catalog.json Outdated Show resolved Hide resolved
ibm_catalog.json Outdated Show resolved Hide resolved
ibm_catalog.json Outdated Show resolved Hide resolved
ibm_catalog.json Outdated Show resolved Hide resolved
tests/pr_test.go Outdated Show resolved Hide resolved
solutions/access-management/variables.tf Outdated Show resolved Hide resolved
solutions/access-management/variables.tf Outdated Show resolved Hide resolved
solutions/access-management/variables.tf Outdated Show resolved Hide resolved
solutions/access-management/variables.tf Outdated Show resolved Hide resolved
@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

@MatthewLemmond you must be in the team github-collaborators in order to trigger the pipeline.

@MatthewLemmond
Copy link
Member Author

/run pipeline

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

@MatthewLemmond you must be in the team github-collaborators in order to trigger the pipeline.

@Ak-sky
Copy link
Member

Ak-sky commented Jun 3, 2024

/run pipeline

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

@Ak-sky you must be in the team github-collaborators in order to trigger the pipeline.

@ocofaigh
Copy link
Member

ocofaigh commented Jun 4, 2024

Pipeline issue should be resolved now @MatthewLemmond if you rebase and try again

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond MatthewLemmond changed the title feat: add solution with default base access group set feat: add submodule with default base access group set Jun 5, 2024
@MatthewLemmond
Copy link
Member Author

/run pipeline

jor2
jor2 reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@jor2 jor2 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comments, besides that looks good

examples/access-management/main.tf Outdated Show resolved Hide resolved
examples/access-management/variables.tf Outdated Show resolved Hide resolved
examples/access-management/version.tf Outdated Show resolved Hide resolved
modules/access-management/version.tf Outdated Show resolved Hide resolved
modules/access-management/variables.tf Outdated Show resolved Hide resolved
modules/access-management/variables.tf Outdated Show resolved Hide resolved
modules/access-management/variables.tf Outdated Show resolved Hide resolved
modules/access-management/variables.tf Outdated Show resolved Hide resolved
modules/access-management/variables.tf Outdated Show resolved Hide resolved
modules/access-management/variables.tf Outdated Show resolved Hide resolved
@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond MatthewLemmond requested a review from jor2 June 10, 2024 20:20
@MatthewLemmond
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 5bb8ad6 into main Jun 11, 2024
2 checks passed
@ocofaigh ocofaigh deleted the solution branch June 11, 2024 14:41
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jor2 jor2 jor2 approved these changes

@ocofaigh ocofaigh ocofaigh approved these changes

@akocbek akocbek Awaiting requested review from akocbek akocbek is a code owner

@vburckhardt vburckhardt Awaiting requested review from vburckhardt

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MatthewLemmond @Ak-sky @ocofaigh @terraform-ibm-modules-ops @jor2