Rework network ACLs (phase 1) #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-landing-zone-vpc into exp-networkacl
…raform-ibm-landing-zone-vpc into exp-networkacl
vburckhardt
changed the title
rajatagarwal-ibm
previously approved these changes
Feb 28, 2023
SirSpidey
previously approved these changes
Feb 28, 2023
vburckhardt
dismissed stale reviews from SirSpidey and rajatagarwal-ibm
via
2965ad3
rajatagarwal-ibm
previously approved these changes
Feb 28, 2023
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@vburckhardt the PR looks correct to me. Just a consideration about its usage: the current logic wouldn't allow a use-case with customer rules preceded by some ibm internal and vpc rules and followed by some other ibm internal and vpc rules.
|
|
@vbontempi - Yes that's correct. I kept it simple for now based on discussion with a few consumers. We can always enhance as needed if the requirement arise in future. |
gmendel
pushed a commit
to gmendel/landing-zone-vpc
that referenced
this pull request
Mar 29, 2023
* feat: give option to append or prepend ibm rules * feat: add a deny all as last element of the list (this is a best practice, and not mandatory as implicit - but absence typically raise questions) * feat: add prefix "ibmflow-" to ibm rules BREAKING CHANGE: The interface of the `network_acls` input variable has changed. If your code is setting this variable explicitly, this change requires to add a few extra optional parameters: `add_ibm_cloud_internal_rules`, `add_vpc_connectivity_rules`, `prepend_ibm_rules` . The parameter `add_cluster_rules` has been renamed `add_ibm_cloud_internal_rules`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial step in the right direction #357
In this PR:
Types of changes in this PR
#357
No release required
Release required
x.x.X): Change that fixes an issue and is compatible with earlier versions)x.X.x): Change that adds functionality and is compatible with earlier versions)X.x.x): Change that is likely incompatible with previous versions)Release notes content
Replace this text with information that users need to know about the bug fixes, features, and breaking changes. This information helps the merger write the commit message that is published in the release notes for the module.
Checklist for reviewers
Merge actions for mergers
Merge by using "Squash and merge".
Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).