fix: Acls created for network cidr are open to Any IP

[Aashiq-J]

Description

Fix the issue of acls created for network cidr which allows any IP.
More details: #542 (comment)

Types of changes in this PR

Changes that affect the core Terraform module or submodules

• Bug fix
• New feature
• Dependency update

Changes that don't affect the core Terraform module or submodules

• Examples or tests (addition or updates of examples or tests)
• Documentation update
• CI-related update (pipeline, etc.)
• Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

• fix to the bug which was introduced in v7.3.0.
• The logic was creating inbound rule for each network_cidr with Any IP in the destination field.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

• Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
• Merge by using "Squash and merge".

[Aashiq-J]

/run pipeline

[Aashiq-J]

[Aashiq-J]

Also updated the loop so that
for inbound:
each of the network_cidr -> each of the vpc address prefix

for outbound:
each of the vpc address prefix -> each of the network_cidr

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[Aashiq-J]

/run pipeline

[ocofaigh]

/run pipeline

[jojustin]

I see Conall has approved this PR. Just merging this PR.

[terraform-ibm-modules-ops]

🎉 This PR is included in version 7.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀