Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow existing subnet public gateway attachment #709

Merged

Conversation

toddgiguere
Copy link
Contributor

Description

Allow existing subnets to be attached to public gateways.

This change alters the input variable existing_subnet_ids to existing_subnets, and the type has changed from simple list of IDs to an array of objects containing the existing subnet ID and a boolean to direct attachment of public gateway.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Allow existing subnets to be attached to public gateways.

  • input variable existing_subnet_ids renamed to existing_subnets
  • type of input chaged from list(string) to list(object)
  • existing subnet object contains ID of subnet and boolean for public gateway attachment

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@toddgiguere
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 3dc79b8 into terraform-ibm-modules:main Jan 4, 2024
2 checks passed
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants