fix: change acl for_each conditional to fix bug

[toddgiguere]

Description

Fix a Terraform bug with a conditional statement. Instead of ternary style we are switching to a "for loop with if condition" style for the ACL resource to avoid the bug.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[toddgiguere]

/run pipeline

[toddgiguere]

All tests are passing so far, so looks like we can avoid this bug:

• PR tests passing, including upgrade tests (passed)
• test existing default landing zone configuration (passed)
• test multiple ACL/rules configuration that caused bug (passed)
• test ACL skipped for existing subnets (passed)

[toddgiguere]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 7.16.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀