Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to disable auto addr prefix for individual subnets #741

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

toddgiguere
Copy link
Contributor

@toddgiguere toddgiguere commented Feb 26, 2024

Description

Added a new property to the subnet input variable map, no_addr_prefix, that if set to "true" will not automatically create a new matching address prefix for the subnet, no matter the condition.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

@toddgiguere
Copy link
Contributor Author

/run pipeline

1 similar comment
@toddgiguere
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit cad676e into terraform-ibm-modules:main Feb 27, 2024
2 checks passed
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 7.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants