fix: vpc data full output on first apply

[jor2]

Description

vpc_data: output var in patterns vsi module does not give complete output on first apply

terraform-ibm-modules/terraform-ibm-landing-zone#777

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

fix for vpc_data: output var in patterns vsi module does not give complete output on first apply.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[ocofaigh]

Perhaps we could add a test which would of caught this. For example take a look at the logic here which is checking the output of the code that runs in the test to ensure it contains certain values.

[surajsbharadwaj]

Hello Team,

Any target date for this to get fixed ? Our new architecture relies on the subnet groups ids required for VPN and ALB creation.

[jor2]

Hello Team,

Any target date for this to get fixed ? Our new architecture relies on the subnet groups ids required for VPN and ALB creation.

Hi @surajsbharadwaj, sorry for the delay I was on holidays last week. I'll get it reviewed and hopefully merged and released tomorrow.

[jor2]

Perhaps we could add a test which would of caught this. For example take a look at the logic here which is checking the output of the code that runs in the test to ensure it contains certain values.

vpc_data previously wasn't included in the outputs for the default example. Now that it is included won't RunTestConsistency catch if there is an issue on reapply?

[jor2]

/run pipeline

[surajsbharadwaj]

@jor2 welcome thank. Thank you for prioritising this work. :)

[jor2]

/run pipeline

[jor2]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 7.18.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀