Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modified to use the latest terraform version #133

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

imprateeksh
Copy link
Member

Description

  • Optional attributes are removed in order to support latest terraform version i.e.
    experiments = [module_variable_optional_attrs]
  • Terraform version is updated i.e.required_version = ">= 1.3.0"

Tick the relevant boxes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Examples / tests (addition or updates of examples or tests)
  • Documentation update
  • CI related update (pipeline, etc)

Checklist:

  • If relevant, a test for the change has been added / updated as part of this PR.
  • If relevant, documentation for the change has been added / updated as part of this PR.

Merge:

Merge using "Squash and merge" and ensure to use a relevant conventional commit message based on the PR contents (this ultimately determines if a new version of the modules needs to be released, and if so, which semver number should be used).

@imprateeksh imprateeksh self-assigned this Nov 10, 2022
ocofaigh
ocofaigh previously approved these changes Nov 10, 2022
BREAKING CHANGE: module is no longer supported on terraform versions lower than 1.3
@ocofaigh ocofaigh marked this pull request as ready for review January 26, 2023 09:47
@ocofaigh
Copy link
Member

depends on terraform-ibm-landing-zone-vpc supporting tf 1.3

@ocofaigh ocofaigh merged commit c298721 into main Jan 26, 2023
@ocofaigh ocofaigh deleted the 2858-tf-version-update branch January 26, 2023 10:09
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants