Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore changes in image #423

Merged
merged 1 commit into from
Apr 11, 2023
Merged

feat: ignore changes in image #423

merged 1 commit into from
Apr 11, 2023

Conversation

Aayush-Abhyarthi
Copy link
Contributor

@Aayush-Abhyarthi Aayush-Abhyarthi commented Apr 10, 2023

Description

This PR adds lifecycle block in the vsi module to ignore_changes in the image parameter.

Types of changes in this PR

terraform-ibm-modules/terraform-ibm-landing-zone#361

No release required

  • Examples or tests (addition or updates of examples or tests)
  • Documentation update
  • CI-related update (pipeline, etc.)
  • Other changes that don't affect Terraform code

Release required

  • Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
  • New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
  • Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content

Add lifecycle block in the vsi module to ignore changes in the image version.


Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • Merge by using "Squash and merge".

  • Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.

    The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

@Aayush-Abhyarthi Aayush-Abhyarthi changed the title fix: ignore changes in image feat: ignore changes in image Apr 11, 2023
@jojustin jojustin merged commit fa137e0 into main Apr 11, 2023
@jojustin jojustin deleted the ignore_changes_in_image branch April 11, 2023 10:56
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants