feat: additional load balancer config #536
Conversation
…rraform-ibm-landing-zone-vsi into configurable-lb
|
/run pipeline |
|
/run pipeline |
|
@rajatagarwal-ibm It seems we have no examples or tests that actually test adding load balancers to VSIs. Can we add an example (or maybe just update the fscloud example) to do this? That way consumers can see how to use the variable, and we test it as part of our tests |
|
@ocofaigh sure, let me update fscloud example to consume LB |
|
@rajatagarwal-ibm maybe actually it makes sense to create a new example. Perhaps a custom example where we provision the module with extra customisations such as load balancer and additional data volumes. Check if we have other gaps too. |
|
@ocofaigh sure, other than Loadbalancer, there are "Secondary Interface Variables" which are not used in the fscloud example. Perhaps I can add Load Balancer and "Secondary Interface Variables" to the new example. Should I also remove "block_storage_volumes" from the FSCloud example to the new custom example? |
|
I think you can leave it in the fscloud example, since it would test being encrypted using HPCS. |
|
As discussed with @ocofaigh, I will be creating a new example "complete" which creates LB and Secondary Interface. I will also use Key Protect for encryption in this example which will enable parallel execution of FSCloud tests(uses HPCS) with the complete tests. Along with that, I will also update tests:
|
|
@rajatagarwal-ibm In #539 Steve has added placement group support and updated the basic example to use it. I think it should be moved the complete example you are going to create |
|
/run pipeline |
SKIP UPGRADE TEST
…rraform-ibm-landing-zone-vsi into configurable-lb
|
/run pipeline |
SKIP UPGRADE TEST
|
/run pipeline |
SKIP UPGRADE TEST
|
/run pipeline |
SKIP UPGRADE TEST
examples/complete/README.md
Outdated
| @@ -0,0 +1,10 @@ | |||
| # Complete Example | |||
There was a problem hiding this comment.
Complete Example using a placement group, attaching a load balancer, and adding additional data volumes
There was a problem hiding this comment.
@rajatagarwal-ibm The title was not updated here?
There was a problem hiding this comment.
Ah its below - it needs to be in title so its exposed in main readme
examples/complete/README.md
Outdated
| - A new public SSH key if one is not passed in. | ||
| - A new VPC with 3 subnets | ||
| - A new placement group | ||
| - A VSI in each subnet |
examples/complete/README.md
Outdated
| - A new VPC with 3 subnets | ||
| - A new placement group | ||
| - A VSI in each subnet | ||
| - A new Application Load Balancer |
There was a problem hiding this comment.
A new Application Load Balancer to balance traffic between all virtual servers that are created by this example
examples/complete/variables.tf
Outdated
| ) | ||
| }) | ||
| default = null | ||
| } |
There was a problem hiding this comment.
I would just remove this from the example if we are not passing any value for it
examples/complete/variables.tf
Outdated
| description = "User data to initialize VSI deployment" | ||
| type = string | ||
| default = null | ||
| } |
There was a problem hiding this comment.
I would just remove this from the example if we are not passing any value for it
examples/complete/variables.tf
Outdated
| description = "CRN of boot volume encryption key" | ||
| type = string | ||
| default = null | ||
| } |
examples/complete/variables.tf
Outdated
| description = "Number of VSI instances for each subnet" | ||
| type = number | ||
| default = 1 | ||
| } |
There was a problem hiding this comment.
can we just pass this in directly to in the example main.tf - no need to expose as a variable in the example
examples/complete/variables.tf
Outdated
| type = string | ||
| description = "Name for VPC" | ||
| default = "vpc" | ||
| } |
There was a problem hiding this comment.
remove this from here - use the prefix variable for vpc name
SKIP UPGRADE TEST
|
/run pipeline |
SKIP UPGRADE TEST
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
The landing-zone-vsi module by default created an Application load balancer with the primary network interface subnet. The actual resource ibm_is_lb allows to configure these variables using profile and subnets. This PR adds them as optional config.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
Merge actions for mergers